On Wed, Oct 2, 2024 at 12:14 PM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > You could consider adding a way to turn it off then instead of turning > it on. > > Imho, since Rust enforces code formatting style I see no point in not > immediately failing the build because of formatting issues. For maintainers, it would be better if we could unconditionally do it, but like with other diagnostics, it is a balance. If there is a way out (like something like `WERROR` or perhaps a "dev mode" like `make D=1` that could encompass other bits), then I think it should be OK. Any preference? (We also need to be careful about `rustfmt` having e.g. bugs in future versions that change the output, but since we are in the Rust CI and we can test the nightly compiler, the risk should be low.) Cheers, Miguel
