On Tue, Oct 01, 2024 at 05:45:15PM GMT, Miguel Ojeda wrote: > On Tue, Oct 1, 2024 at 4:17 PM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > Ok. Why does it pass the build then? Seems like it should just fail the build. > > It is part of `make rustfmt` / `make rustfmtcheck`. > > I would be happy to make it part of the normal build if people agree > -- though it could be annoying in some cases, e.g. iterating small > changes while developing. You could consider adding a way to turn it off then instead of turning it on. > > If we do that, it would be nice if -next does it too, but I think > Stephen is already building Rust for x86_64 allmodconfig (Cc'd). Imho, since Rust enforces code formatting style I see no point in not immediately failing the build because of formatting issues.