On Fri, Apr 19, 2024 at 10:05 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > It's a bit awkward that the ioctl number is checked twice, though. Maybe rename > the new function to fuse_setup_special_ioctl() and call it unconditionally? > > - Eric I'm happy to change it but the benefit of the current iteration is that it's much more obvious to someone unfamiliar with the code that code path is only used for fs-verity. Admittedly, I may be overindexing on the importance of that as someone who's trying to learn the codebase myself. Let me know if you still prefer I change it