----- Ursprüngliche Mail ----- > Von: "chengzhihao1" <chengzhihao1@xxxxxxxxxx> > An: "Matthew Wilcox" <willy@xxxxxxxxxxxxx>, "linux-fsdevel" <linux-fsdevel@xxxxxxxxxxxxxxx> > CC: "David Woodhouse" <dwmw2@xxxxxxxxxxxxx>, "richard" <richard@xxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx> > Gesendet: Montag, 22. April 2024 16:46:37 > Betreff: Re: [PATCH 14/30] jffs2: Remove calls to set/clear the folio error flag > 在 2024/4/20 10:50, Matthew Wilcox (Oracle) 写道: >> Nobody checks the error flag on jffs2 folios, so stop setting and >> clearing it. We can also remove the call to clear the uptodate >> flag; it will already be clear. >> >> Convert one of these into a call to mapping_set_error() which will >> actually be checked by other parts of the kernel. >> >> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx> >> Cc: Richard Weinberger <richard@xxxxxx> >> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx >> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> >> --- >> fs/jffs2/file.c | 14 +++----------- >> 1 file changed, 3 insertions(+), 11 deletions(-) > > xfstests passed. Looks like the change is harmless. > > Tested-by: Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx> Acked-by: Richard Weinberger <richard@xxxxxx> Thanks, //richard
