On Mon, 22 Apr 2024 at 18:31, Richard Fung <richardfung@xxxxxxxxxx> wrote: > > On Fri, Apr 19, 2024 at 10:05 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > It's a bit awkward that the ioctl number is checked twice, though. Maybe rename > > the new function to fuse_setup_special_ioctl() and call it unconditionally? > > > > - Eric > > I'm happy to change it but the benefit of the current iteration is > that it's much more obvious to someone unfamiliar with the code that > code path is only used for fs-verity. Admittedly, I may be > overindexing on the importance of that as someone who's trying to > learn the codebase myself. > > Let me know if you still prefer I change it Or move the switch out to the caller and split fuse_setup_verity_ioctl() into two separate functions, since there's no commonality between them (except that both are verity related). I did that transformation and pushed it to git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next Please verify that I didn't mess anything up. Thanks, Miklos
