On Mon, Nov 27, 2023 at 03:53:36PM +0100, Christian Brauner wrote: > On Mon, Nov 27, 2023 at 02:59:45PM +0100, Christoph Hellwig wrote: > > This looks ok, but I still find these locking helper so horrible to > > follow.. > > What do you still find objectionable? Same thing as last time. The __ helpers that take the share/exclusive trip me off every single time I have to follow them. Just open coding the calls to the rw_semaphore helpers is a lot easier to read in general, but for anything complex that actually needs an enum with EXCL and SHARED in it would at least makes it clear what is happening.
