On Tue, Jul 18, 2023 at 11:31:49PM -0700, Christoph Hellwig wrote: > On Wed, Jul 19, 2023 at 07:53:32AM +0200, Christian Brauner wrote: > > On vacation until next. Please add a proper rationale why and who this > > export is needed by in the commit message. As right now it looks like > > someone thought it would be good to have which is not enough for > > something to become an export. > > emergency_sync is a relaly bad idea and has all kinds of issues. > It should go away and not grow more users outside of core code, > and the one Guenther points to should never have been added. > > If we want to allow emergency shutdowns it needs a proper interface > and not a remount read-only ignoring some rules that tends to make > things worse and instad of better, and even for that I'm not sure > I want modules to be able to drive it. I am not sure why you would not want modules to use it - in the case we have here we detect a catastrophic failure in a critical system component (embedded controller crashed) and would like to have as much of the logs saved as possible. It is a module because this kind of EC may not be present on every system, but when it is present it is very much a core component. Thanks. -- Dmitry
