On Tue, Jul 18, 2023 at 05:13:06PM -0500, Bill O'Donnell wrote: > On Tue, Jul 18, 2023 at 09:45:40PM +0000, Rob Barnes wrote: > > emergency_sync forces a filesystem sync in emergency situations. > > Export this function so it can be used by modules. > > > > Signed-off-by: Rob Barnes <robbarnes@xxxxxxxxxx> > > Example of an emergency situation? An example from existing code in drivers/firmware/arm_scmi/scmi_power_control.c: static inline void scmi_request_forceful_transition(struct scmi_syspower_conf *sc) { dev_dbg(sc->dev, "Serving forceful request:%d\n", sc->required_transition); #ifndef MODULE emergency_sync(); #endif Arguably emergency_sync() should also be called if the file is built as module. Either case, I think it would make sense to add an example to the commit description. Thanks, Guenter