On Wed, Jun 03 2009, Artem Bityutskiy wrote: > Jens Axboe wrote: >>> Just to make sure I understood you correctly. I assume my original >>> patch is fine (because there is bdi_destroy()) and merge it to >>> ubifs tree. >> >> It needs to be: >> >> err = bdi_register(&c->bdi, NULL, "ubifs"); >> if (err) >> goto out_bdi; >> >> so you hit the bdi_destroy() for that failure, not goto out_close; >> Otherwise it was fine. > > Ah, I see. Rather non-typical convention though. I expected > bdi_register() to clean-up stuff in case of failure. Isn't > it a better interface? You already did a bdi_init() at that point. bdi_destroy() must be used to clean up after both bdi_init() and/or bdi_register(). -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
