On Fri, May 29 2009, Artem Bityutskiy wrote: > Peter Zijlstra wrote: >> On Thu, 2009-05-28 at 17:19 +0300, Artem Bityutskiy wrote: >>> Artem Bityutskiy wrote: >>>> question is - should it? 'bdi_register()' a block device, >>>> but we do not have one. >>> Sorry, wanted to say: 'bdi_register()' registers a block >>> device. >> >> BDI stands for backing device info and is not related to block devices >> other than that block devices can also be (ok, always are) backing >> devices. >> >> If you want to do writeback, you need a backing device to write to. The >> BDI is the device abstraction for writeback. > > I see, thanks. The below UBIFS patch fixes the issue. I'll > push it to ubifs-2.6.git tree, unless there are objections. > > From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> > Subject: [PATCH] UBIFS: do not forget to register BDI device > > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> > --- > fs/ubifs/super.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 2349e2c..d1ac967 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -1929,6 +1929,9 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) > err = bdi_init(&c->bdi); > if (err) > goto out_close; > + err = bdi_register(&c->bdi, NULL, "ubifs"); > + if (err) > + goto out_close; Not quite right, you need to call bdi_destroy() if you have done the init. I committed this one this morning: http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=570a2fe1df85741988ad0ca22aa406744436e281 But feel free to commit/submit to the ubifs tree directly, then it'll disappear from my tree once it is merged. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
