Re: [PATCH 01/22] fs: Pass an iocb to generic_perform_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/22] fs: Pass an iocb to generic_perform_write()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 22 Feb 2022 22:51:39 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20220222194820.737755-2-willy@infradead.org>

> -extern ssize_t generic_perform_write(struct file *, struct iov_iter *, loff_t);
> +extern ssize_t generic_perform_write(struct kiocb *, struct iov_iter *);

Please drop the extern and spell out the parameter names while you're at
it.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 01/22] fs: Pass an iocb to generic_perform_write()
  - From: Matthew Wilcox

References:
- [PATCH 00/22] Remove aop flags
  - From: Matthew Wilcox (Oracle)
- [PATCH 01/22] fs: Pass an iocb to generic_perform_write()
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: linux-next: Tree for Feb 22 (NFSD_V2_ACL)
Next by Date: Re: [PATCH 02/22] fs: Move pagecache_write_begin() and pagecache_write_end()
Previous by thread: [PATCH 01/22] fs: Pass an iocb to generic_perform_write()
Next by thread: Re: [PATCH 01/22] fs: Pass an iocb to generic_perform_write()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux