On Tue, Feb 22, 2022 at 07:48:00PM +0000, Matthew Wilcox (Oracle) wrote: > These functions are now simple enough to be static inlines. They > should also be in pagemap.h instead of fs.h because they're > pagecache functions. I wonder if we should keep them at all. For the core fs code calling the methods directly seems perfectly fine. And the calles in the file systems should just call the implementations and avoid the indirection. And the callers in i915 look very suspicious.