On Tue, Feb 22, 2022 at 10:51:39PM -0800, Christoph Hellwig wrote: > > -extern ssize_t generic_perform_write(struct file *, struct iov_iter *, loff_t); > > +extern ssize_t generic_perform_write(struct kiocb *, struct iov_iter *); > > Please drop the extern and spell out the parameter names while you're at > it. I don't mind dropping the 'extern', but I don't see the value in naming the parameters. For something like 'int' or 'void *', you need to know what kind of thing you're dealing with, but if you're passing one kiocb, calling it 'iocb' gives no extra information. If you're passing two, then knowing which is 'src' and which is 'dest' is useful. > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
