Re: [PATCH 29/35] Btrfs ioctl code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-01-15 at 12:17 -0800, Linus Torvalds wrote:
> 
> On Fri, 16 Jan 2009, Ryusuke Konishi wrote:
> 
> > Hi Chris,
> > On Wed,  7 Jan 2009 22:57:19 -0500, Chris Mason wrote:
> > > +
> > > +struct btrfs_ioctl_vol_args {
> > > +	__s64 fd;
> > > +	char name[BTRFS_PATH_NAME_MAX + 1];
> > > +};
> > 
> > The size of btrfs_ioctl_vol_args seems to depend on architectures.
> > 
> > For example, the size was 3084 bytes on a x86-32 machine, but was 3088
> > bytes on a x86-64 machine.
> 
> Grr. Different alignment for 64-bit values, coupled with "name" not 
> having a size that is a multiple-of-eight.
> 

Will the fd and the start of the name get aligned differently?  I'll fix
it up

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux