On Fri, 16 Jan 2009, Ryusuke Konishi wrote:
> Hi Chris,
> On Wed, 7 Jan 2009 22:57:19 -0500, Chris Mason wrote:
> > +
> > +struct btrfs_ioctl_vol_args {
> > + __s64 fd;
> > + char name[BTRFS_PATH_NAME_MAX + 1];
> > +};
>
> The size of btrfs_ioctl_vol_args seems to depend on architectures.
>
> For example, the size was 3084 bytes on a x86-32 machine, but was 3088
> bytes on a x86-64 machine.
Grr. Different alignment for 64-bit values, coupled with "name" not
having a size that is a multiple-of-eight.
Chris, I think we want to fix this. Even if it breaks binary
compatibility with previous tools. I don't think we want to have compat
ioctls for something that is so close to already working.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
