Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
From: Tony Luck <tony.luck@xxxxxxxxx>
Date: Mon, 7 Oct 2019 12:49:19 -0700
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <CAHk-=wi3P2NvBNocyNFTAb-G08P0ASVihMVKmiw__oNU4V2M5g@mail.gmail.com>

On Mon, Oct 7, 2019 at 12:09 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> Hmm? I thought ia64 did unaligneds ok.

If PSR.ac is set, we trap. If it isn't set, then model specific
(though all implementations will
trap for an unaligned access that crosses a 4K boundary).

Linux sets PSR.ac. Applications can use prctl(PR_SET_UNALIGN) to choose whether
they want the kernel to silently fix things or to send SIGBUS.

Kernel always noisily (rate limited) fixes up unaligned access.

Your patch does make all the messages go away.

Tested-by: Tony Luck <tony.luck@xxxxxxxxx>

Follow-Ups:
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds

References:
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Guenter Roeck
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Guenter Roeck
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Al Viro
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Al Viro
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Tony Luck
- Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
  - From: Linus Torvalds

Prev by Date: Re: WARNING in filldir64
Next by Date: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
Previous by thread: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
Next by thread: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]