On Mon, Oct 7, 2019 at 11:28 AM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Oct 6, 2019 at 8:11 PM Linus Torvalds > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > The last two should just do user_access_begin()/user_access_end() > > > instead of access_ok(). __copy_to_user_inatomic() has very few callers as well: > > > > Yeah, good points. > > Looking at it some more this morning, I think it's actually pretty painful. Late to this party ,,, but my ia64 console today is full of: irqbalance(5244): unaligned access to 0x2000000800042f9b, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fbb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fdb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042ffb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x200000080004301b, ip=0xa0000001002fef90 ia64_handle_unaligned: 95 callbacks suppressed irqbalance(5244): unaligned access to 0x2000000800042f9b, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fbb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fdb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042ffb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x200000080004301b, ip=0xa0000001002fef90 ia64_handle_unaligned: 95 callbacks suppressed Those ip's point into filldir64() -Tony
