On Wed, Apr 02, 2008 at 04:25:10PM +1000, Barry Naujok wrote:
> + struct qstr *a,
> + struct qstr *b)
> +{
> + int result = xfs_dir_compname(XFS_I(dir->d_inode), a->name, a->len,
> + b->name, b->len) == XFS_CMP_DIFFERENT;
> + /*
> + * result == 0 if a match is found, and if so, copy the name in "b"
> + * to "a" to cope with negative dentries getting the correct name.
> + */
> + if (result == 0)
> + memcpy((unsigned char *)a->name, b->name, a->len);
> + return result;
qstr->name is marked const for a reason, please don't overwrite
it after it's creation.
> +struct dentry_operations xfs_ci_dentry_operations =
> +{
struct dentry_operations xfs_ci_dentry_operations = {
> +static xfs_dahash_t
> +xfs_ascii_ci_hashname(
is the use of STATIC now officially phased out for XFS?
> + ((sbp)->sb_versionnum & XFS_SB_VERSION_OLDCIBIT);
no need for the braces around sbp
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
