On Thu, Apr 03, 2008 at 11:29:12AM +1000, David Chinner wrote: > > +#define xfs_dir_hashname(dp, n, l) \ > > + ((dp)->i_mount->m_dirnameops->hashname((n), (l))) > > + > > +#define xfs_dir_compname(dp, n1, l1, n2, l2) \ > > + ((dp)->i_mount->m_dirnameops->compname((n1), (l1), (n2), (l2))) > > + > > Static inline functions, please. Or kill them completely. I find the common Linux style that jut opencodes method invocations a lot more readable. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html