On Thu, Apr 03, 2008 at 11:53:31AM +1000, David Chinner wrote: > > + if (xfs_sb_version_hasoldci(&mp->m_sb)) > > + sb->s_root->d_op = &xfs_ci_dentry_operations; > > Write a helper function for this: xfs_set_ci_dentry_ops(mp, dentry) > rather than exporting the xfs_ci_dentry_operations structure. yes, please. also the export ops calling d_alloc_anon need to update the dentry ops aswel and should be using this one. > > +#define XFS_SB_VERSION_OLDCIBIT 0x4000 /* ASCII only case-insens. */ > > #define XFS_SB_VERSION_MOREBITSBIT 0x8000 > > #define XFS_SB_VERSION_OKSASHFBITS \ > > Whitespace. > > But it's a shame you're being sensible about this - I kinda liked > the Irix name for this feature (XFS_SB_VERSION_BORGBIT). :) So what exactly prevents us from using it in Linux? please use the old name. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
