[PATCH 0/2] record errors in mapping when writeback fails on DAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is part of the preparatory set of patches to pave the way for
improved writeback error reporting. In order to do this correctly, we
need to ensure that DAX marks the mapping with an error when writeback
fails.

I sent the second patch in this series to Ross last week, but he pointed
out that it makes fsync error out more than it should, since we don't
currently clear errors in filemap_write_and_wait and
filemap_write_and_wait_range.

In order to fix that, I think we need the first patch in this set. There
is a some danger that this could end up causing error flags to be
cleared earlier than they were before when write initiation fails in
other filesystems.

Given how racy all of the AS_* flag handling is though, I'm inclined to
just go ahead and merge both of these into linux-next and deal with any
fallout as it arises.

Does that seem like a reasonable plan? If so, Andrew, would you be
willing to take both of these in for linux-next, with an eye toward
merging into v4.13?

Thanks in advance,

Jeff Layton (2):
  mm: clear any AS_* errors when returning from
    filemap_write_and_wait{_range}
  dax: set errors in mapping when writeback fails

 fs/dax.c     | 4 +++-
 mm/filemap.c | 8 ++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

-- 
2.9.4




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux