[vfs:work.uaccess 87/89] arch/blackfin/kernel/flat.c:35:3: note: in expansion of macro 'pr_debug'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Al,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.uaccess
head:   90ccb624044e623d9a41be2b49bd017de1a8ce0b
commit: 9c02566c78f0b05d078677c8a4e6f3c0ae380a69 [87/89] binfmt_flat: flat_{get,put}_addr_from_rp() should be able to fail
config: blackfin-BF537-STAMP_defconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 9c02566c78f0b05d078677c8a4e6f3c0ae380a69
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from arch/blackfin/kernel/flat.c:7:
   arch/blackfin/kernel/flat.c: In function 'bfin_get_addr_from_rp':
   include/linux/kern_levels.h:4:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/printk.h:136:11: note: in definition of macro 'no_printk'
       printk(fmt, ##__VA_ARGS__); \
              ^~~
   include/linux/kern_levels.h:14:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:12: note: in expansion of macro 'KERN_DEBUG'
     no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
               ^~~~~~~~~~
>> arch/blackfin/kernel/flat.c:35:3: note: in expansion of macro 'pr_debug'
      pr_debug("*ptr = %lx", get_unaligned(ptr));
      ^~~~~~~~
   arch/blackfin/kernel/flat.c: In function 'bfin_put_addr_at_rp':
   include/linux/kern_levels.h:4:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/printk.h:136:11: note: in definition of macro 'no_printk'
       printk(fmt, ##__VA_ARGS__); \
              ^~~
   include/linux/kern_levels.h:14:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:12: note: in expansion of macro 'KERN_DEBUG'
     no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
               ^~~~~~~~~~
   arch/blackfin/kernel/flat.c:80:3: note: in expansion of macro 'pr_debug'
      pr_debug("new ptr =%lx", get_unaligned(ptr));
      ^~~~~~~~

vim +/pr_debug +35 arch/blackfin/kernel/flat.c

9c02566c Al Viro        2017-05-02  19  		u32 *persistent)
1394f032 Bryan Wu       2007-05-06  20  {
1394f032 Bryan Wu       2007-05-06  21  	unsigned short *usptr = (unsigned short *)ptr;
1394f032 Bryan Wu       2007-05-06  22  	int type = (relval >> 26) & 7;
9c02566c Al Viro        2017-05-02  23  	u32 val;
1394f032 Bryan Wu       2007-05-06  24  
1394f032 Bryan Wu       2007-05-06  25  	switch (type) {
1394f032 Bryan Wu       2007-05-06  26  	case FLAT_BFIN_RELOC_TYPE_16_BIT:
1394f032 Bryan Wu       2007-05-06  27  	case FLAT_BFIN_RELOC_TYPE_16H_BIT:
1394f032 Bryan Wu       2007-05-06  28  		usptr = (unsigned short *)ptr;
1394f032 Bryan Wu       2007-05-06  29  		pr_debug("*usptr = %x", get_unaligned(usptr));
1394f032 Bryan Wu       2007-05-06  30  		val = get_unaligned(usptr);
1394f032 Bryan Wu       2007-05-06  31  		val += *persistent;
1394f032 Bryan Wu       2007-05-06  32  		break;
1394f032 Bryan Wu       2007-05-06  33  
1394f032 Bryan Wu       2007-05-06  34  	case FLAT_BFIN_RELOC_TYPE_32_BIT:
1394f032 Bryan Wu       2007-05-06 @35  		pr_debug("*ptr = %lx", get_unaligned(ptr));
1394f032 Bryan Wu       2007-05-06  36  		val = get_unaligned(ptr);
1394f032 Bryan Wu       2007-05-06  37  		break;
1394f032 Bryan Wu       2007-05-06  38  
1394f032 Bryan Wu       2007-05-06  39  	default:
1f83b8f1 Mike Frysinger 2007-07-12  40  		pr_debug("BINFMT_FLAT: Unknown relocation type %x\n", type);
1394f032 Bryan Wu       2007-05-06  41  		return 0;
1394f032 Bryan Wu       2007-05-06  42  	}
1394f032 Bryan Wu       2007-05-06  43  

:::::: The code at line 35 was first introduced by commit
:::::: 1394f03221790a988afc3e4b3cb79f2e477246a9 blackfin architecture

:::::: TO: Bryan Wu <bryan.wu@xxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux