On Tue, 2017-05-30 at 07:10 -0400, Jeff Layton wrote: > This is part of the preparatory set of patches to pave the way for > improved writeback error reporting. In order to do this correctly, we > need to ensure that DAX marks the mapping with an error when writeback > fails. > > I sent the second patch in this series to Ross last week, but he pointed > out that it makes fsync error out more than it should, since we don't > currently clear errors in filemap_write_and_wait and > filemap_write_and_wait_range. > > In order to fix that, I think we need the first patch in this set. There > is a some danger that this could end up causing error flags to be > cleared earlier than they were before when write initiation fails in > other filesystems. > > Given how racy all of the AS_* flag handling is though, I'm inclined to > just go ahead and merge both of these into linux-next and deal with any > fallout as it arises. > > Does that seem like a reasonable plan? If so, Andrew, would you be > willing to take both of these in for linux-next, with an eye toward > merging into v4.13? > > Thanks in advance, > There is an alternative here though... In the series that I have that adds in the new writeback error reporting infrastructure, I've added a fstype flag that indicates what flavor of error reporting the filesystem does. We could just have DAX check that flag and only mark the mapping for error if it's set. That should make things work with the new scheme while preserving the old as much as possible. Now that I think about it, that's probably the safest avenue. Let's just drop both of these patches, and I'll just roll a patch like that into the later series. Sorry for the noise, -- Jeff Layton <jlayton@xxxxxxxxxx>
