On Thu, May 4, 2017 at 4:59 PM, Christoph Hellwig <hch@xxxxxx> wrote: > On Thu, May 04, 2017 at 04:57:51PM +0300, Amir Goldstein wrote: >> I did consider defining uuid_t as uuid_be. >> most of the patch set would have remained the same and >> xfs_uuid_getnodeuniq() would use struct uuid_v1 explicitly >> instead of implicitly. > > At least don't add new users of uuid_v1. Moving that stuff into > uuid.[ch] was a major mistake, and I wish review would have caught > it back then. Fine. I can keep xfs_uu_t for now. It's not really a part of the effort to move the generic helpers to uuid.h.
