On Thu, May 04, 2017 at 04:26:17PM +0300, Amir Goldstein wrote: > xfs was defining a non namespaced type named uuid_t and for no good > reason. xfs code doesn't care about the internals of uuid_t struct - > it only cares about its size. > > Re-define uuid_t as the common struct uuid_v1 in include/linux/uuid.h > and get rid of the xfs private definition. I'm not sure this really is a good idea. uuid_v1 currently is only used by afs. I'd much rather switch both afs and xfs to use the uuid_be type (which might as well grow the standard uuid_t name while we're at it), and use accessors that do the byte-array access for the very few places that care about the interpretation. There is some more fallou from this, e.g. generate_random_uuid should also take a uuid_be (and maybe renamed to uuid_generate_random).
