Darick, I moved some code around to be able to hoist all the generic xfs uuid helpers to linux/uuid.h, so that other filesystems and uuid related code in the kernel can use them. Let me know what you think of the outcome. I did not find any uuid related regressions with xfs. Specifically, the following xfstests exercise these changes: xfs/045 xfs/073 xfs/077 (multi uuid mount) generic/079 xfs/238 xfs/269 xfs/062 (fshandle) Some of these helpers are quite similar to thier uuid_{le|be} variants in linux/uuid.h, but at the moment I don't see xfs or any filesystem starting to use the uuid_{le|be} helpers, so we probably have to live with this duplicity for a while longer. Amir. Amir Goldstein (8): xfs: use uuid_copy() helper to abstract uuid_t xfs: re-define uuid_t as common struct uuid_v1 xfs: dismiss xfs_uu_t xfs: namespace the helper uuid_getnodeuniq() md: namespace private helper names linux/uuid.h: hoist helpers uuid_equal() and uuid_copy() from xfs linux/uuid.h: hoist uuid_is_null() helper from libnvdimm xfs: use the common helper uuid_is_null() drivers/md/md.c | 8 ++++---- drivers/nvdimm/btt_devs.c | 10 ++-------- fs/xfs/uuid.c | 42 ++++++------------------------------------ fs/xfs/uuid.h | 14 ++------------ fs/xfs/xfs_inode_item.c | 8 ++------ fs/xfs/xfs_log_recover.c | 6 +++--- fs/xfs/xfs_mount.c | 10 +++++----- include/linux/uuid.h | 21 +++++++++++++++++++-- lib/uuid.c | 3 +++ 9 files changed, 46 insertions(+), 76 deletions(-) -- 2.7.4