uuid_getnodeuniq(), as the comment says, 'is not in any way a standard or condoned UUID function'. Therefore, prefix the helper name with xfs_ to differentiate it from the rest of the common uuid_ helpers. The uuid_ helpers are about to be hoisted to lib/uuid.c. Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> --- fs/xfs/uuid.c | 4 ++-- fs/xfs/uuid.h | 2 +- fs/xfs/xfs_mount.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c index 7bb4fb8..16958e7 100644 --- a/fs/xfs/uuid.c +++ b/fs/xfs/uuid.c @@ -18,13 +18,13 @@ #include <xfs.h> /* - * uuid_getnodeuniq - obtain the node unique fields of a UUID. + * xfs_uuid_getnodeuniq - obtain the node unique fields of a UUID. * * This is not in any way a standard or condoned UUID function; * it just something that's needed for user-level file handles. */ void -uuid_getnodeuniq(uuid_t *uuid, int fsid [2]) +xfs_uuid_getnodeuniq(uuid_t *uuid, int fsid[2]) { fsid[0] = (uuid->clock_seq_hi_and_reserved << 24) | (uuid->clock_seq_low << 16) | diff --git a/fs/xfs/uuid.h b/fs/xfs/uuid.h index 0e3ecd0..b40dee7 100644 --- a/fs/xfs/uuid.h +++ b/fs/xfs/uuid.h @@ -22,7 +22,7 @@ extern int uuid_is_nil(uuid_t *uuid); extern int uuid_equal(uuid_t *uuid1, uuid_t *uuid2); -extern void uuid_getnodeuniq(uuid_t *uuid, int fsid [2]); +extern void xfs_uuid_getnodeuniq(uuid_t *uuid, int fsid[2]); static inline void uuid_copy(uuid_t *dst, uuid_t *src) diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 4c0d8d7..f4fdce7 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -794,7 +794,7 @@ xfs_mountfs( * Copies the low order bits of the timestamp and the randomly * set "sequence" number out of a UUID. */ - uuid_getnodeuniq(&sbp->sb_uuid, mp->m_fixedfsid); + xfs_uuid_getnodeuniq(&sbp->sb_uuid, mp->m_fixedfsid); mp->m_dmevmask = 0; /* not persistent; set after each mount */ -- 2.7.4