On Thu, Jul 05, 2007 at 03:43:32PM -0700, Dave Hansen wrote:
> This takes care of all of the direct callers of vfs_mknod().
> Since a few of these cases also handle normal file creation
> as well, this also covers some calls to vfs_create().
>
> So that we don't have to make three mnt_want/drop_write()
> calls inside of the switch statement, we move some of its
> logic outside of the switch.
Looks good to me.
> One thing I noticed: do we actually _need_ the first
> S_ISDIR() check at the top of the function?
The EPERM is required by Posix.
> + if (!S_ISREG(mode) && !S_ISCHR(mode) && !S_ISBLK(mode) &&
> + !S_ISFIFO(mode) && !S_ISSOCK(mode) && (mode != 0)) {
no need for braces around the mode != 0
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
