On Thu, Jul 05, 2007 at 11:41:00AM -0400, J. Bruce Fields wrote: > OK, after looking at this a little more, I'm less happy about the idea > of erroring out by default: > > - There are a ton of filesystems that probably should allow > leases, and only a few (network filesystems) that shouldn't, > so leaving leases on by default seems simpler. But it gets you possible wrong behaviour by default. I'm not a big fan of non-trivial default methods as you see :) > - We already fall back on the local method by default in the case > of locks, and I don't see a reason to treat leases differently. > - The patch to add > .setlease = setlease, > to all the file_operations is going to be a big patch that > changes behavior in a way that might be easy to miss (because > it changes behavior exactly on those filesystems it *doesn't* > touch.) I think it'll be easier to get better review on the > patch that adds a method just to those filesystems that we're > disabling leases for. Anyway, feel free to go ahead with the simpler version for now, I'll do the switchover for locks and leases when I get some time. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
