"Robert Rappaport" <robert.rappaport@xxxxxxxxx> said: > After looking more carefully at your changes, I have a question. Why > didn't you modify the linux kernel routine, setlease(), so that it > would either call f_op->set_lease() or __setlease()? Instead you > created a new routine, nfs4_setlease(), and you modified the previous > calls to setlease() in nfs4 to now call nfs4_setlease. No good reason that I can see. I think you're correct that the ->setlease() call should go into the common code, and by invoked by fcntl too. --b. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html