This is about the actual fscache code. - there's a bunch of gfp_t-related sparse warnings. I'll send a patch to fix them as a followup to this mail. - the Kconfig hackery is rather ugly. I'd rather express the depencies with selects in this case - the filesystem fscache options select FSCACHE, as does the cachefiles module. Patch will be sent later. - include/linux/fscache.h is an utter mess :) Please reorder the file so there's just a single big #if defined(CONFIG_FSCACHE) || defined(CONFIG_FSCACHE_MODULE) #else #endif block. Doing that will also allow to drop a lot of the __fscache function and directly stub out the non-__ versions. - please remove the #ifdef CONFIG_DEBUG_SLAB BUG_ONs from cookie.c, driver should never deal with slab or slab debugging internals. - various statically initialize structs in main.c set members to NULL, which is not required and should be removed - IIRC k* release callbacks must not be NULL. Please check which Greg on your kset usage - please adjust your comment style to normal linux style. kernel-doc headers for functions please, and no /********/ full line comments - maybe fscache should provide a generic ->mkwrite operation or even a set of otherwise filemap-based vm_operations for it's client filesystems? - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
