Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Biggers <ebiggers@xxxxxxxxxx>
Subject: Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
From: Aleksander Adamowski <olo@xxxxxx>
Date: Thu, 9 Sep 2021 00:55:07 +0000
Accept-language: en-US
In-reply-to: <YTlVHtvjuCxsI0DS@gmail.com>
References: <20210828013037.2250639-1-olo@fb.com> <YTk806ahPPcuz9gl@gmail.com> <SA1PR15MB48240CCB6C38535A022ACADBDDD49@SA1PR15MB4824.namprd15.prod.outlook.com> <YTlL6Josq+79r/ia@gmail.com> <SA1PR15MB48244271F45CF01744C5074EDDD59@SA1PR15MB4824.namprd15.prod.outlook.com> <YTlVHtvjuCxsI0DS@gmail.com>
Suggested_attachment_session_id: 0dfcd4ca-11df-3e5a-8396-e22457b6c811
Thread-index: AQHXm6xcGarxStMvPUS3MVkBynObEauaztiAgAAMJniAAAXVAIAABG9LgAAGjACAAAahJQ==
Thread-topic: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine

On Wednesday, September 8, 2021 5:28 PM, Eric Biggers wrote:
>It's fine to reformat the comments and code if necessary.

Will do.

> It needs to be:
> 
>         if (!certfile) {
>                 libfsverity_error_msg("certfile must be specified");
>                 return -EINVAL;
>         }

{facepalm}

Argh, will fix that in V4 !
How did I miss that. Thanks for catching it!

References:
- [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Aleksander Adamowski
- Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Eric Biggers
- Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Aleksander Adamowski
- Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Eric Biggers
- Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Aleksander Adamowski
- Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
  - From: Eric Biggers

Prev by Date: Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
Next by Date: [fsverity-utils PATCH v4] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
Previous by thread: Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
Next by thread: [GIT PULL] fscrypt updates for 5.15
Index(es):
- Date
- Thread

[Index of Archives] [linux Cryptography] [Asterisk App Development] [PJ SIP] [Gnu Gatekeeper] [IETF Sipping] [Info Cyrus] [ALSA User] [Fedora Linux Users] [Linux SCTP] [DCCP] [Gimp] [Yosemite News] [Deep Creek Hot Springs] [Yosemite Campsites] [ISDN Cause Codes]