On Wed, Sep 08, 2021 at 11:32:29PM +0000, Aleksander Adamowski wrote: > On Wednesday, September 8, 2021 3:44 PM, Eric Biggers wrote: > > Sorry, I didn't notice that you had already sent out a new version of this > > patch. Is this version intended to address all my comments? Some of the > > comments I made don't seem to have been fully addressed. > > Hi! > > Yes, the patch was intended to address all of your previous comment. > > I went over it to double check and noticed that I somehow left one OPENSSL_IS_BORINGSSL ifdef in programs/cmd_sign.c. > > I will remove it in V3. As far as I can tell, all of your other comments are already addressed, unless I'm still missing something? Regarding struct libfsverity_signature_params, I wrote "Please write a comment that clearly explains which parameters must be specified and when.". Also I mentioned "The !OPENSSL_IS_BORINGSSL case no longer returns an error if sig_params->keyfile or sig_params->certfile is unset". That wasn't addressed for sig_params->certfile. - Eric
|