Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Eric Biggers <ebiggers@xxxxxxxxxx>
- Subject: Re: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
- From: Aleksander Adamowski <olo@xxxxxx>
- Date: Wed, 8 Sep 2021 23:32:29 +0000
- Accept-language: en-US
- In-reply-to: <YTk806ahPPcuz9gl@gmail.com>
- References: <20210828013037.2250639-1-olo@fb.com> <YTk806ahPPcuz9gl@gmail.com>
- Suggested_attachment_session_id: 3bc8c5da-1907-14a7-4c28-378978274411
- Thread-index: AQHXm6xcGarxStMvPUS3MVkBynObEauaztiAgAAMJng=
- Thread-topic: [fsverity-utils PATCH v2] Implement PKCS#11 opaque keys support through OpenSSL pkcs11 engine
On Wednesday, September 8, 2021 3:44 PM, Eric Biggers wrote:
> Sorry, I didn't notice that you had already sent out a new version of this
> patch. Is this version intended to address all my comments? Some of the
> comments I made don't seem to have been fully addressed.
Hi!
Yes, the patch was intended to address all of your previous comment.
I went over it to double check and noticed that I somehow left one OPENSSL_IS_BORINGSSL ifdef in programs/cmd_sign.c.
I will remove it in V3. As far as I can tell, all of your other comments are already addressed, unless I'm still missing something?
[Index of Archives]
[linux Cryptography]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
