> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Tuesday, March 21, 2023 9:03 PM
> To: Nicolas Pitre <nico@xxxxxxxxxxx>
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>; Zhang, Tianfei
> <tianfei.zhang@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-fpga@xxxxxxxxxxxxxxx;
> ilpo.jarvinen@xxxxxxxxxxxxxxx; Weight, Russell H <russell.h.weight@xxxxxxxxx>;
> matthew.gerlach@xxxxxxxxxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; Gomes,
> Vinicius <vinicius.gomes@xxxxxxxxx>; Khadatare, RaghavendraX Anand
> <raghavendrax.anand.khadatare@xxxxxxxxx>
> Subject: Re: [PATCH v1] ptp: add ToD device driver for Intel FPGA cards
>
> On Mon, Mar 20, 2023 at 04:53:07PM -0400, Nicolas Pitre wrote:
> > On Mon, 20 Mar 2023, Richard Cochran wrote:
> >
> > > On Mon, Mar 20, 2023 at 09:43:30AM -0400, Nicolas Pitre wrote:
> > >
> > > > Alternatively the above commit can be reverted if no one else
> > > > cares. I personally gave up on the idea of a slimmed down Linux
> > > > kernel a while ago.
> > >
> > > Does this mean I can restore the posix clocks back into the core
> > > unconditionally?
> >
> > This only means _I_ no longer care. I'm not speaking for others (e.g.
> > OpenWRT or the like) who might still rely on splitting it out.
> > Maybe Andy wants to "fix" it?
>
> I would be a good choice, if I have an access to the hardware at hand to test.
> That said, I think Richard himself can try to finish that feature (optional PTP) and on
> my side I can help with reviewing the code (just Cc me when needed).
>
Hi Richard, Andy,
Handle NULL as a valid parameter (object) to their respective APIs looks a good idea, but this will be a big change and need fully test for all devices,
we can add it on the TODO list. So for this patch, are you agree we continue use the existing ptp_clock_register() API, for example, change my driver like below:
dt->ptp_clock = ptp_clock_register(&dt->ptp_clock_ops, dev);
if (IS_ERR_OR_NULL(dt->ptp_clock))
return dev_err_probe(dt->dev, IS_ERR_OR_NULL(dt->ptp_clock),
"Unable to register PTP clock\n");
