RE: [PATCH v1] uio: dfl: add HSSI feature id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Wu, Hao <hao.wu@xxxxxxxxx>
> Sent: Tuesday, March 15, 2022 5:32 PM
> To: Zhang, Tianfei <tianfei.zhang@xxxxxxxxx>; Weight, Russell H
> <russell.h.weight@xxxxxxxxx>; trix@xxxxxxxxxx; mdf@xxxxxxxxxx; linux-
> fpga@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: Xu, Yilun <yilun.xu@xxxxxxxxx>; Matthew Gerlach
> <matthew.gerlach@xxxxxxxxxxxxxxx>
> Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> 
> > > -----Original Message-----
> > > From: Wu, Hao <hao.wu@xxxxxxxxx>
> > > Sent: Monday, March 14, 2022 11:09 AM
> > > To: Zhang, Tianfei <tianfei.zhang@xxxxxxxxx>; Weight, Russell H
> > > <russell.h.weight@xxxxxxxxx>; trix@xxxxxxxxxx; mdf@xxxxxxxxxx;
> > > linux- fpga@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx
> > > Cc: Xu, Yilun <yilun.xu@xxxxxxxxx>; Matthew Gerlach
> > > <matthew.gerlach@xxxxxxxxxxxxxxx>
> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > >
> > > > > -----Original Message-----
> > > > > From: Wu, Hao <hao.wu@xxxxxxxxx>
> > > > > Sent: Friday, March 11, 2022 10:47 AM
> > > > > To: Weight, Russell H <russell.h.weight@xxxxxxxxx>; Zhang,
> > > > > Tianfei <tianfei.zhang@xxxxxxxxx>; trix@xxxxxxxxxx;
> > > > > mdf@xxxxxxxxxx; linux- fpga@xxxxxxxxxxxxxxx;
> > > > > gregkh@xxxxxxxxxxxxxxxxxxx
> > > > > Cc: Xu, Yilun <yilun.xu@xxxxxxxxx>; Matthew Gerlach
> > > > > <matthew.gerlach@xxxxxxxxxxxxxxx>
> > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > > >
> > > > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > > > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> > > > > > >
> > > > > > > Add the feature id of the OFS High Speed Serial Interface
> > > > > > > subsystem to table of ids supported by the uio_dfl driver.
> > > > > > >
> > > > > > > Signed-off-by: Matthew Gerlach
> > > > > > > <matthew.gerlach@xxxxxxxxxxxxxxx>
> > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@xxxxxxxxx>
> > > > > >
> > > > > > Reviewed-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> > > > > > > ---
> > > > > > >  drivers/uio/uio_dfl.c | 2 ++
> > > > > > >  1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > > > > index
> > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > > > --- a/drivers/uio/uio_dfl.c
> > > > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct
> > > > > > > dfl_device
> > > > > > > *ddev) }
> > > > > > >
> > > > > > >  #define FME_FEATURE_ID_ETH_GROUP	0x10
> > > > > > > +#define FME_FEATURE_ID_OFS_HSSI		0x15
> > > > >
> > > > > Where is the "OFS" coming from? is it for all OFS device or a specific
> card?
> > > > > Anyway, could we have a matched name per public table?
> > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-fea
> > > > > ture
> > > > > -ids.rst
> > > >
> > > > Yes, I think a matched name of public table will be better. How about the "
> > > > FME_FEATURE_ID_HSSI"?
> > >
> > > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h
> > > #define FME_FEATURE_ID_HSSI		0x6
> >
> > Is it possible change the "FME_FEATURE_ID_HSSI" to "
> > FME_FEATURE_ID_LEGACY_HSSI", and the new one is "
> > FME_FEATURE_ID_HSSI"?
> 
> I am not sure who owns the ID allocation table, and why
> 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix for
> this HSSI instead, I hope we don't have to change this 0x15 HSSI to another
> legacy one when someone adds a new HSSI. This is for FPGA, everybody could
> implement his own HSSI, generic name should be avoid when possible, and a
> better rule when managing the feature IDs.

Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better.

> 
> >





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux