> > -----Original Message----- > > From: Wu, Hao <hao.wu@xxxxxxxxx> > > Sent: Friday, March 11, 2022 10:47 AM > > To: Weight, Russell H <russell.h.weight@xxxxxxxxx>; Zhang, Tianfei > > <tianfei.zhang@xxxxxxxxx>; trix@xxxxxxxxxx; mdf@xxxxxxxxxx; linux- > > fpga@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx > > Cc: Xu, Yilun <yilun.xu@xxxxxxxxx>; Matthew Gerlach > > <matthew.gerlach@xxxxxxxxxxxxxxx> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > > > > > > > > Add the feature id of the OFS High Speed Serial Interface subsystem > > > > to table of ids supported by the uio_dfl driver. > > > > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@xxxxxxxxx> > > > > > > Reviewed-by: Russ Weight <russell.h.weight@xxxxxxxxx> > > > > --- > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > --- a/drivers/uio/uio_dfl.c > > > > +++ b/drivers/uio/uio_dfl.c > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > > > > } > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > Where is the "OFS" coming from? is it for all OFS device or a specific card? > > Anyway, could we have a matched name per public table? > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst > > Yes, I think a matched name of public table will be better. How about the " > FME_FEATURE_ID_HSSI"? No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h #define FME_FEATURE_ID_HSSI 0x6 Need a new matched name. Hao > > > > > Hao > > > > > > > > > > static const struct dfl_device_id uio_dfl_ids[] = { > > > > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > > > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, > > > > { } > > > > }; > > > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
