Re: [PATCH 2/2] viafb: Add OLPC XO-1.5 port configs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28 October 2010 23:04, Jonathan Corbet <corbet@xxxxxxx> wrote:
> Could you refresh my memory on that original patch?
>
> I guess we could put something into the via-core initialization that
> says:
>
>        if (machine_is_olpc())
>                turn_02c_to_gpio();
>
> That covers only your case, and not that of anybody else who will have
> wired up a board differently, but we can let them generalize it when
> they run into trouble :)

Thats pretty much what I posted:
http://www.spinics.net/lists/linux-fbdev/msg01681.html

I now realise that all the #ifdefs are unnecessary, the code should be
there unconditionally and the compiler will remove it on non-OLPC
kernels.

The other option we have is to detect the XO-1.5 using DMI. That's the
more conventional way of detecting a specific platform in the kernel.
Florian, what do you think?

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux