Re: [PATCH 2/2] viafb: Add OLPC XO-1.5 port configs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(cc'ed Jon)

Daniel Drake schrieb:
On 21 September 2010 18:15, Florian Tobias Schandinat
<FlorianSchandinat@xxxxxx> wrote:
Why? What happens if this patch is not applied?
Please understand, that I, as a maintainer, try to avoid platform specific
code as much as possible so a little explanation would be good.

Without the patch, the GPIO/I2C lines are not set up correctly so
we're unable to access the hardware connected there.

*after a deeper look at the patch*
Hm, one of my patches enables 0x26 also as I2C. So the only difference between the current config and your config is whether 0x2c is GPIO or I2C where your version make a lot more sense.
Jon, do you agree that this should become the default config?
Handling a GPIO device as such and not as an I2C device sounds right to me, although we have to take care about the old code which is doing so.


Thanks,

Florian Tobias Schandinat
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux