Re: [PATCH] viafb: Use proper register for bgcolor when doing MONO blits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 21, 2010 at 10:07 AM, Daniel Drake <dsd@xxxxxxxxxx> wrote:
> On 21 September 2010 18:00, Florian Tobias Schandinat
> <FlorianSchandinat@xxxxxx> wrote:
>> Not really. For color blits it looks like we're doing the right thing here,
Yes you are but the code says.

 if (op == VIA_BITBLT_MONO)

*snip*
>
> Odd. That's exactly what we get on VX855 before the patch.
>

I must admit I didn't look at the code thoroughly because I am more
interested in getting my KMS code finished.  The proper fix is to have
color blits use fgcolor 0x4C and bgcolor use 0x50 and mono blits use
fgcolor 0x58 and bgcolor 0x5C.

My patch would have broken color blits, but is technically correct.
Hope that gives you the information you need to properly fix the
problem.

Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux