On 2022/9/8 16:56, Ritesh Harjani (IBM) wrote:
On 22/09/03 11:01AM, Jason Yan wrote:
Factor out ext4_encoding_init(). No functional change.
Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
Reviewed-by: Jan Kara <jack@xxxxxxx>
---
fs/ext4/super.c | 80 +++++++++++++++++++++++++++----------------------
1 file changed, 44 insertions(+), 36 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index f8806226b796..67972b0218c0 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4521,6 +4521,48 @@ static int ext4_inode_info_init(struct super_block *sb,
return 0;
}
+static int ext4_encoding_init(struct super_block *sb, struct ext4_super_block *es)
+{
+#if IS_ENABLED(CONFIG_UNICODE)
How about simplying it like below.
if (!IS_ENABLED(CONFIG_UNICODE))
return 0;
<...>
Then we don't need #ifdef CONFIG_UNICODE
Nice idea. Will update.
Thanks
Jason
