Hi Ritesh, thanks for the review.
On 2022/9/8 16:44, Ritesh Harjani (IBM) wrote:
On 22/09/03 11:01AM, Jason Yan wrote:
Factor out ext4_set_def_opts(). No functional change.
if (blocksize == PAGE_SIZE)
set_opt(sb, DIOREAD_NOLOCK);
The patch looks good however, even this ^^ could be moved in
ext4_set_def_opts() via some refactoring.
If required you could even submit a seperate change for above.
Yes, this needs some refactoring. I would like to make a separate patch
in my next series.
Jason
Otherwise this change looks good to me.
Reviewed-by: Ritesh Harjani (IBM)<ritesh.list@xxxxxxxxx>
