This function is maybe the longest function I have seen in the kernel. It has more than one thousand lines. This makes us not easy to read and understand the code. So I made some refactors. The first two patches did some preparation to the goto labels so that we can factor out some functions easily. After this refactor this function is about 500 lines shorter. I did not go further because I'm not sure if people like this kind of change. If there is any bad side effects, please let me know. If you strongly dislike it, I am ok to stop this refactor. v1->v2: some code improvements suggested by Jan Kara and add review tags. Jason Yan (13): ext4: goto right label 'failed_mount3a' ext4: remove cantfind_ext4 error handler ext4: factor out ext4_set_def_opts() ext4: factor out ext4_handle_clustersize() ext4: factor out ext4_fast_commit_init() ext4: factor out ext4_inode_info_init() ext4: factor out ext4_encoding_init() ext4: factor out ext4_init_metadata_csum() ext4: factor out ext4_check_feature_compatibility() ext4: factor out ext4_geometry_check() ext4: factor out ext4_group_desc_init() and ext4_group_desc_free() ext4: factor out ext4_load_and_init_journal() ext4: factor out ext4_journal_data_mode_check() fs/ext4/super.c | 1070 ++++++++++++++++++++++++++--------------------- 1 file changed, 599 insertions(+), 471 deletions(-) -- 2.31.1
