On Tue 12-07-16 12:59:08, Jan Kara wrote: > On Mon 11-07-16 13:12:42, Ted Tso wrote: > > On Mon, Jul 11, 2016 at 06:15:56PM +0200, Jan Kara wrote: > > > > > > What would you like to achieve with this? There is 'QF_META' format which > > > is different from 'QF_XFS' format basically only in the set of quotactls > > > used. As I said above it might be nice to separate kernel-api from the > > > underlying-quota-format but in reality these two were bound together in > > > older kernels so they are not really independent. > > > > The main reason why I noticed is with the new (err, "latest") ext4 > > quota (enabled via mke2fs -t ext4 -O quota) implementation, we enable > > quota tracking at mount time. (This may be true with journalled quota > > as well, actually). But we don't actually enable quota *enforcement* > > until quotaon is given. > > Yes. > > > The problem is that quotaon -p prints the status of whether or not > > quota *tracking* is enabled, and with the new ext4 quota, quota > > tracking is *always* enabled. So quota -p doesn't report anything > > useful for new ext4 quota systems, and when I started to look at how > > to change things, that's when I noticed that we weren't using the new > > quotactl commands with ext4 even though they worked, and that the new > > quotactl implementation had more functionality than the older ones. > > OK. But with XFS you'd notice that quotaon -p also returns 'on' whenever > the accounting is turned on. So ext4 and xfs behave in the same way. > Arguably it would be more useful if quotaon -p reported 'off', 'accounting', > 'enforcement'. Maybe I'll do that. This is now done and push out to quota-tools repository. When XGETSTAT quotactl is available, 'quotaon -pva' will report whether the quota is enabled only for accounting or also enforced. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
