On Fri, Jul 08, 2016 at 10:51:27AM +1000, Dave Chinner wrote: > On Wed, Jul 06, 2016 at 09:47:28PM -0500, Eric Sandeen wrote: > > On 7/6/16 6:35 PM, Dave Chinner wrote: > > > > ... > > > > >> +_require_scratch > > >> +_require_chattr > > >> +_require_test_lsattr > > >> +_require_quota > > > > > > needs _require_prjquota, and that function needs to be modified to > > > detect for both XFS and ext4 support. > > > > I think that if there is desire to test both xfs and non-xfs userspace > > with project quota, then we need to differentiate between "e2fsprogs > > and linux-quota and the kernel all support it" and "xfsprogs and > > the kernel both support it" don't we? > > Well, it should be just "linux-quota and kernel". ext4 needs to > have the same mount option behaviour for project quota as it does > for all other types of quota, not be dependent on mkfs.... Project quota for ext4 is an optional thing, and if nothing else, we need to have a separate feature flag for legacy file systems that were created before we started supporting project quota. So if you want to support project quota you *will* need to have a version of e2fsck that understands project quota, and a version of mke2fs that knows how to request that project quota be enabled, etc., etc. So while it might be *nice* if ext4 could support project quota without being dependent on having a specific version of mke2fs and e2fsck installed, it's just simply not possible.... > > IOWs if the test uses setquota/repquota, chattr, mkfs, and fsck to > > work with project quota, then that's a different set of requirements > > from a test using xfs_io, xfs_quota, etc. > > _require_linux_prjquota > _require_xfs_prjquota > > But that said, both ext4 and xfs need to work for both > configurations, and they should all be using the common xfstests > quota infrastructure.... Agreed, but we want xfstests to be able to support systems where linux-quota (aka quotatools) and/or e2fsprogs and/or the kernel haven't been upgraded to support project quota, don't we? If for no other reason than to be kind to the poor souls who have to support RHEL 6. :-) - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
