On Tue, Dec 16, 2014 at 02:59:43PM +1100, Dave Chinner wrote: > > Yes, that is too long for an "auto" test. A couple of minutes is > about the limit we should be trying to stick to for auto tests; we > don't really add any extra coverage by making such tests run for a > long time. > > As it is, most of the xfsdump/restore tests take around 30-60s to > run, so that's probably a good guide to follow for this. I'm currently running with a patch that cuts it down to ~22 seconds (and about 60 megs worth of data in the dump and restore directory). I'll send a patch.... > > And I'll note that using the current fsstress arguments, you are only > > creating regular files and directories, and there are no symlinks, > > device nodes, or FIFO's being created to test whether those files are > > correctly being backed up and restored. > > Probably a good idea, too. Thanks for looking at this, Ted. I looked a bit more closely at this, and unfortunately it's not a quick fix. The issue is that the test is currently using diff -r to verify that the restore directory == the dump directory, and diff doesn't handle special files. Doing this right might require writing a special case directory comparison script in perl, or some such; if we do this, then we can also have the directory comparison tool also check to make sure the uid/gid/mode bits match, which diff also doesn't handle. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
