Re: [PATCH] ext4/004: add dump/restore test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 15, 2014 at 09:58:27PM -0500, Theodore Ts'o wrote:
> On Mon, Dec 08, 2014 at 09:44:48AM +0800, Xiaoguang Wang wrote:
> > 
> > Yeah, my intent is to test dump/restore program, and indeed I imitate that
> > how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in
> > corresponding xfs directory.
> 
> I'm finding that the test takes 6-7 minutes to run, partially because
> it's writing close to half a gigabyte worth of data for the
> dump/restore.  Is this really necessary?  Can we perhaps cut down the
> amount of data generated by running fsstress?

Yes, that is too long for an "auto" test. A couple of minutes is
about the limit we should be trying to stick to for auto tests; we
don't really add any extra coverage by making such tests run for a
long time.

As it is, most of the xfsdump/restore tests take around 30-60s to
run, so that's probably a good guide to follow for this.

> And I'll note that using the current fsstress arguments, you are only
> creating regular files and directories, and there are no symlinks,
> device nodes, or FIFO's being created to test whether those files are
> correctly being backed up and restored.

Probably a good idea, too. Thanks for looking at this, Ted.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux