Hi, On 12/07/2014 05:40 AM, Theodore Ts'o wrote: > On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote: >> This test case will first use fsstress to fill a file system, then >> dump it to standard output and restore it from standard input, finally >> check that the original contents and the new contents generated by >> restore tool will be same. >> >> Signed-off-by: Xiaoguang Wang <wangxg.fnst@xxxxxxxxxxxxxx> > > One question --- what is the intent of this test? Is it to test the > kernel, or the dump/restore program? I have not bothered putting > regression tests for e2fsprogs in xfstests, because if I'm developing > e2fsprogs, it actually makes much more sense to put the regression > tests in the e2fsprogs git tree. Yeah, my intent is to test dump/restore program, and indeed I imitate that how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in corresponding xfs directory. Regards, Xiaoguang Wang > > If this is because it's more convenient to put this in xfsprogs > because it has fsstress, maybe we should adjust the groups that it is > in so that it's not in auto or quick, but some other group? Or add it > to some group like "userspace" so I can exclude it when I'm mostly > interested in testing development kernels? > > Thanks, > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
