On Tue 02-09-14 18:05:47, Ted Tso wrote: > Instead of initializing the allocation_request structure in > ext4_alloc_branch(), set it up in ext4_ind_map_blocks(), and then pass > it to ext4_alloc_branch() and ext4_splice_branch(). > > This allows ext4_ind_map_blocks to pass flags in the allocation > request structure without having to add Yet Another argument to > ext4_alloc_branch(). The patch looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> BTW: > - goal = new_blocks[i] = ext4_new_meta_blocks(handle, inode, > - goal, 0, NULL, &err); > + ar->goal = new_blocks[i] = ext4_new_meta_blocks(handle, > + ar->inode, ar->goal, 0, NULL, &err); This seems to suggest ext4_new_meta_blocks() would be better off by taking allocation_request argument as well? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
