On Wed, Sep 03, 2014 at 06:25:52PM +0200, Jan Kara wrote: > This seems to suggest ext4_new_meta_blocks() would be better off by > taking allocation_request argument as well? I thought about it, but the problem is that ext4_new_meta_blocks() is called in many more places than ext4_alloc_branch(). So in this patch, it was just a metter of moving some code from one function to its (single) caller. In the case of ext4_new_meta_blocks(), we would needing to replicate that that code in four or five places, and we were passing in the mb_flags field anyway, so it wasn't a case of needing to add yet another argument to a function that had many more arguments to start with. So I decided it wasn't worth the effort. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
